NO-ISSUE: Upgrade docker-client to 25.x and remove deprecated tests #515
+1,154
−884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
changed the title
wmedvede
approved these changes
Aug 8, 2024
rhkp
pushed a commit
to rhkp/kogito-serverless-operator
that referenced
this pull request
Aug 9, 2024
…pache#515) Signed-off-by: Ricardo Zanini <[email protected]>
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Aug 26, 2024
…pache#515) Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This issue involves manually upgrading Docker to the 25.x version, as done by our friend here #512. Part of this upgrade was to remove an outdated Heroku Docker client library that was being used by non-relevant rests in the
container-builderpackage.Also, there was a CVE in our main k8s dependency core, which was fixed too.
Motivation for the change:
Stay away from CVEs.
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.